feat: enhance MCPServer env var configuration with EnvVarCfg type#109
Draft
drewhemm wants to merge 3 commits intokagent-dev:mainfrom
Draft
feat: enhance MCPServer env var configuration with EnvVarCfg type#109drewhemm wants to merge 3 commits intokagent-dev:mainfrom
drewhemm wants to merge 3 commits intokagent-dev:mainfrom
Conversation
…rCfg type Signed-off-by: Andrew Hemming <andrew@footprintit.net>
17ec232 to
061fceb
Compare
Signed-off-by: Andrew Hemming <andrew@footprintit.net>
…ring and object formats Signed-off-by: Andrew Hemming <andrew@footprintit.net>
77027a3 to
c76e8aa
Compare
Contributor
|
This is a super creative way to do this. I think in the long term we should just break this and move to the k8s API, but this could be a good stop gap. Is there a reason this is still in draft? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address #98
It maintains backwards compatibility for specifying env vars using simple strings (
value), but also adds the ability to specify object values, which unlock the ability to usevalueFrom, to source individual env vars from secrets, configmaps and the Downward API.Example: