-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to work with Gnome Shell 3.6 #33
base: master
Are you sure you want to change the base?
Conversation
olibjerd, why this commit? it doesn't fix anything. |
Just changing the version does not make this work with 3.6: JS LOG: Extension "pidgin-conversation-integration@kagesenshi.org" had error: Error: No JS module 'telepathyClient' found in search path |
i'm not on gnome 3.6 yet .. but from what l300lvl mentioned .. got a feeling that this plugin might need a major update .. js module telepathyClient no longer around? >.< |
Well after looking closer the location has changed: const TelepathyClient = imports.ui.telepathyClient; becomes const TelepathyClient = imports.ui.components.telepathyClient; so it isn't gone and with this change the extension does enable, but it doesn't work, and there are other major changes to the module which need worked out |
ah ok then .. thanks l300lvl .. i'll poke on this once i'm on Fedora18beta/gnome3.6 .. F18beta should be out around end of this month .. |
Thanks for looking into this. Waiting for your extension to work in gnome shell 3.6 :) |
I dig into the source and work out a merely working version at my fork, not perfect at all, and only works for 3.6(considering those grate changes brought by upstream api.) |
update those ICON thing. https://github.com/pentie/gnome-shell-extensions-pidgin The gnome-shell code is too complicated, i don't know how to pull avatar from pidgin, I let it be the default one. The unread counter not working (yet) And My version ONLY works for 3.6, thus I think not to pull request to @kagesenshi at the moment, it's better to branch them in the repository, the 3.6 API changes and it's difficult to make it work with all versions. |
@Pentie works for me for now, thanks a lot |
any news @kagesenshi ? I really love this extension |
try to use this fork => https://github.com/thedeadparrot/gnome-shell-extensions-pidgin/commits/master |
@marcelometal why don't you send a pull request or something? This definitely works! EDITWhen you type in the message in the popup, it's not marked as read, hence notification icon ain't updated (keeps blinking). Which is a bugger. =/ |
@Pentie Unfortunately I can't open issues on your forks page, that's why I'm putting it here. |
seems like i myself havent got around to fix this .. too busy with work Plone stuff .. any of the forks are working well? .. i can give direct access to here if there are people who are interested in continuing maintaining this ..waiting for me might take a too long .. |
@olebowle I'm in gnome-shell 3.8 too but, I switched to empathy which I find had done a lot of improvement, it's more usable then ever. The gnome-shell API is changing so much and the document is scarce, it's too harsh for me to keep this plugin working. Hope someone else would do that ... :) |
I was hoping for the same. ;-) |
As for the dbus stuff a quick google revealed it has some big changes in 3.8, hopefully this may be of some help: https://github.com/aleho/hamster-shell-extension/commit/8b4ba78c5abe6616cbf68c82736d4898e9e2373c |
yeah .. every release the API for the TelepathyClient notification changed .. :( .. probably this plugin need a new rewrite, so that it doesnt rely on TelepathyClient stuff .. |
Why did I only read this comment thread AFTER my pain of getting this 3.8 ready. |
No description provided.