Fix FastGPT disappearing on settings toggle #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoBernardino
commented
Jan 26, 2024
Comment on lines
+213
to
+224
| async function kagiSummarize(info) { | ||
| // The linkUrl will be undefined if function is triggered by a page event. In that case, the url is taken from pageUrl | ||
| const url = info.linkUrl || info.pageUrl; | ||
| browser.tabs.create({ | ||
| url: `https://kagi.com/summarizer/index.html?url=${encodeURIComponent( | ||
| url, | ||
| )}`, | ||
|
|
||
| await browser.windows.create({ | ||
| url: browser.runtime.getURL( | ||
| `src/summarize_result.html?url=${encodeURIComponent(url)}`, | ||
| ), | ||
| focused: true, | ||
| width: 600, | ||
| height: 500, | ||
| type: 'popup', |
There was a problem hiding this comment.
These changes fix opening up in the popup instead of a new tab with the summarizer (#45).
BrunoBernardino
commented
Jan 26, 2024
Comment on lines
+276
to
+280
| fastGptSection.style.display = 'none'; | ||
| } else { | ||
| summarizeSection.style.display = ''; | ||
| requestPermissionsSection.style.display = 'none'; | ||
| fastGptSection.style.display = ''; |
There was a problem hiding this comment.
These changes fix FastGPT disappearing when toggling settings (#64).
BrunoBernardino
commented
Jan 26, 2024
| @@ -89,11 +89,16 @@ async function setup() { | |||
|
|
|||
| const searchParams = new URLSearchParams(window.location.search); | |||
|
|
|||
| // If there's no URL, get the currently active tab and default params | |||
| if (!searchParams.get('url')) { | |||
| if (!searchParams.get('summary_type')) { | |||
There was a problem hiding this comment.
The changes in this file allow the popup to be initialized with just a URL param (right click context open), otherwise not all parameters would've been properly set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change the context summarization to open in the popup as the extension, instead of a new tab.
This will be released on 0.5.1.
Fixes #45
Fixes #64
kagi_chrome_0.5.1.zip
kagi_firefox_0.5.1.zip