Add sortable tables #639
Open
Add sortable tables #639
+673
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! |
it can't correctly sort between 128K and 1M, as an example
|
I've added some more changes. Like custom formatting for numbers, so 1M and 128K can be properly sorted and displayed in human readable form. Also, added custom formatting for any specified token words, like "Mistral", "Meta", etc. |
|
I didn't highlight anything in the last table, the llm cost, since I didn't understand the logic behind it. |
|
What was the issue with #634 ? |
|
It wasn't working correctly. On page switch all the event listeners were reset so sorting stopped working. Also, I think tanstack is production tested and more suitable than my custom implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at sortable table, this time I've used https://tanstack.com/table/latest
I've updated only 1 table as an example to show how it can be used in the markdown document.
I also didn't verify if LLM properly converted Markdown table into JSON 🙈