-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated Package Structure and Developer Tools #20
base: main
Are you sure you want to change the base?
Conversation
…DME and embedding
.devcontainer/devcontainer.json
Outdated
@@ -0,0 +1,14 @@ | |||
// For format details, see https://aka.ms/devcontainer.json. For config options, see the | |||
{ | |||
"image": "ghcr.io/swarm-io-internal/docker:latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm.. may not appropriate here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha @kapilt! I can remove the .devcontainer
. I had added it because it makes open source contribution and trying out the package easier and faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, if you would like me to keep the devcontainer
but adjust the Docker image, I can create an auto-building Docker image in your org, so you don't have to reference my organization.
Clarifying, this is a drive my comment, I’m not a maintainer on this repo.
…On Fri, May 17, 2024 at 5:26 PM Cordero Core ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .devcontainer/devcontainer.json
<#20 (comment)>:
> @@ -0,0 +1,14 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+{
+ "image": "ghcr.io/swarm-io-internal/docker:latest",
In addition, if you would like me to keep the devcontainer but adjust the
Docker image, I can create an auto-building Docker image in your org, so
you don't have to reference my organization.
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFJERQGFZMHNU3QC7LTI3ZCZYYTAVCNFSM6AAAAABGP7KXXSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRUGQYTMNZYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Oh okay! Would you recommend that I just remove the Codespaces functionality? |
Either that or reference a public image
…On Fri, May 17, 2024 at 5:58 PM Cordero Core ***@***.***> wrote:
Oh okay! Would you recommend that I just remove the Codespaces
functionality?
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFJEWL7R7M3AHRE3IAIC3ZCZ4QNAVCNFSM6AAAAABGP7KXXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYGQZDQNZSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Done. |
@vprelovac definitely understandable. A lot of the changes are just updating to modern packaging standards. I also added in some framework, so you can create a |
The purpose of this PR is to update the package structure to modern Python development standards and add developer tools. These changes should allow the package to be more sustainable and extensible while encouraging more open source contribution over time.
Features
Package Structure
Developer Tools
__init__.py
files for local package importing