Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat BVH animation data as an asset and create an asset loader for it #21

Merged
merged 7 commits into from
May 11, 2024

Conversation

nixon-voxell
Copy link
Collaborator

Closes #16

@nixon-voxell nixon-voxell added the enhancement New feature or request label Apr 29, 2024
@ConquerorFY ConquerorFY marked this pull request as ready for review April 29, 2024 15:13
Copy link
Collaborator Author

@nixon-voxell nixon-voxell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ConquerorFY here are some suggestions I made, basically removing RenderAsset related code and using Resource to keep track of all handles.

src/animation_loader.rs Outdated Show resolved Hide resolved
src/animation_loader.rs Outdated Show resolved Hide resolved
src/animation_loader.rs Outdated Show resolved Hide resolved
src/animation_loader.rs Outdated Show resolved Hide resolved
src/animation_loader.rs Outdated Show resolved Hide resolved
@nixon-voxell nixon-voxell merged commit 1b2125b into main May 11, 2024
6 checks passed
@nixon-voxell nixon-voxell deleted the feature/bvh-animation-data-asset branch May 11, 2024 14:40
@nixon-voxell nixon-voxell added this to the v0.1.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Treat BVH animation data as an asset and create an asset loader for it
2 participants