Expose NewGoofys in github.com/kahing/goofys/api package
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? |
kahing
reviewed
Aug 23, 2018
api/api.go
Outdated
| var ( | ||
| GetStdLogger = internal.GetStdLogger | ||
| InitLoggers = internal.InitLoggers | ||
| MassaageMountFlags = internal.MassageMountFlags |
|
Sorry for the delay, I haven't had much time with goofys lately. This looks fine, although I am a little hesitate to expose more internal APIs, but since goofys still is in 0.x and people should expect API changes, I guess it's ok. Could you squash your commits? |
extending and mounting elsewhere.
|
@kahing Thanks for getting back to me. I squashed the commits and fixed the spelling of massage. For what it's worth, the changes only expose additional functions so the API changes are backwards compatible. |
|
ping @kahing -- I think it's ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently extending
goofysto add local caching for some specific use cases in whichcatfsdoes not serve our needs. However, the current API of thegoofys/apipackage is very limited (as it only allows you to mount). It would be really useful to be able to create agoofys/internal.Goofysstruct such that certain functions of thegithub.com/jacobsa/fuse/fuseutil.FileSysteminterface can be overridden; but the associated goofys functions and types are currently walled off in thegoofys/internalpackage, which cannot be imported.This PR exposes a few of the functions and types from the
internalpackage that enable extendinggoofys. I also added aGetFullNamefunction I've found very useful. This PR makes no functional changes but would be awesome to have incorporated into the codebase from an extensibility standpoint.