Escape the special char in name correctly. As per the AWS documentat… #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, CopyRequest is sending request param and it advised to URLEncode the source name. Using the url.QueryEscape to encode the name instead of urlPahEscape since it does not cover all special char.
|
Fixes #580 |
skuppa
commented
Nov 6, 2020
| @@ -475,7 +475,7 @@ func (s *S3Backend) mpuCopyPart(from string, to string, mpuId string, bytes stri | |||
| params := &s3.UploadPartCopyInput{ | |||
| Bucket: &s.bucket, | |||
| Key: &to, | |||
| CopySource: aws.String(pathEscape(from)), | |||
| CopySource: aws.String(url.QueryEscape(from)), | |||
There was a problem hiding this comment.
Use the QueryEscape to encode URLEncode the params.
| @@ -667,7 +667,7 @@ func (s *S3Backend) CopyBlob(param *CopyBlobInput) (*CopyBlobOutput, error) { | |||
|
|
|||
| params := &s3.CopyObjectInput{ | |||
| Bucket: &s.bucket, | |||
| CopySource: aws.String(pathEscape(from)), | |||
| CopySource: aws.String(url.QueryEscape(from)), | |||
There was a problem hiding this comment.
Use the QueryEscape to encode URLEncode the params. The from is a leaf node (just name, not a path) hence QueryEscape will escape all special characters. Even if the from has a forward slash (/) then it will be escaped and AWS unescaping and working correctly.
| @@ -571,13 +571,6 @@ func mapAwsError(err error) error { | |||
| } | |||
| } | |||
|
|
|||
| // note that this is NOT the same as url.PathEscape in golang 1.8, | |||
There was a problem hiding this comment.
Removed since it is not used anywhere.
monthonk
suggested changes
Aug 11, 2022
|
merged via 5ae08c0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape the special char in name correctly. As per the AWS documentation, CopyRequest is sending request param and it advised to URLEncode the source name. Using the
url.QueryEscapeto encode the name instead ofurl.PahEscapesince it does not cover all special char.