Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure dependencies to recent, stable version #680

Closed
wants to merge 2 commits into from

Conversation

philwinder
Copy link
Contributor

The dependencies listed in the go.mod are pointing to azure libraries that have interfaces that goofys won't work with.

This PR updates the code to use the correct interfaces (I defaulted to empty options, this may not be appropriate) and then I could update the library versions to the most recent.

This fixes #664 and similar build issues.

Where the API requires new parameters, I used an empty struct. Although this compiles, it may not be approproate for the use of the code.
@dannycjones
Copy link

dannycjones commented Jun 28, 2022

@philwinder do you have a peer that can review and run the tests for these changes? I think its a case of running CLOUD=azblob make run-tests with the correct credentials configured as well. I don't have access to an Azure account nor the context at the moment to review changes for Azure back-end.

run-tests.sh shows some environment variables that can be set to configure for Azure:

goofys/test/run-tests.sh

Lines 46 to 66 in c6e678c

elif [ $CLOUD == "azblob" ]; then
: ${AZURE_STORAGE_ACCOUNT:="devstoreaccount1"}
: ${AZURE_STORAGE_KEY:="Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw=="}
: ${ENDPOINT:="http://127.0.0.1:8080/${AZURE_STORAGE_ACCOUNT}/"}
if [ ${AZURE_STORAGE_ACCOUNT} == "devstoreaccount1" ]; then
if ! which azurite >/dev/null; then
echo "Azurite missing, run:" >&1
echo "npm install -g azurite" >&1
exit 1
fi
rm -Rf /tmp/azblob
mkdir -p /tmp/azblob
PROXY_BIN="azurite-blob -l /tmp/azblob --blobPort 8080 -s"
#PROXY_BIN="azurite-blob -l /tmp/azblob --blobPort 8080 -d /dev/stdout"
fi
export AZURE_STORAGE_ACCOUNT
export AZURE_STORAGE_KEY
export ENDPOINT

I'm hoping we can get this PR reviewed by a member of the community, then final review and merge from Ka-Hing, allowing users to build and install Goofys using go install.

@dannycjones
Copy link

dannycjones commented Jun 28, 2022

Would it be possible for you to rebase to pick up the update to the fuse lib in 829d8e5?

Currently we see the following error when building, which seems related to the FUSE lib updated in that commit. When I rebase on top of 829d8e5, build is OK.

$ make build
go build -ldflags "-X main.Version=`git rev-parse HEAD`"
# github.com/kahing/goofys
github.com/jacobsa/fuse/internal/buffer.memclr: relocation target runtime.memclrNoHeapPointers not defined for ABI0 (but is defined for ABIInternal)
make: *** [Makefile:13: build] Error 2

@kahing
Copy link
Owner

kahing commented Nov 3, 2022

closing via cc76eec

@kahing kahing closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation on MacOS using go install fails
3 participants