Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading slashes from examples #174

Closed
wants to merge 1 commit into from

Conversation

dhamaniasad
Copy link

When following the examples from the README, code like this does not work:

Api.addRoute('/Post/', {
  get: function () {
    return "Hello, World!";
  }
});

And removing the leading slash from Api.addRoute('/Post/') makes it work.

@kahmali
Copy link
Owner

kahmali commented Mar 8, 2016

Hey @dhamaniasad. Thanks for the PR! I'm so sorry it took me this long to respond. I thought I did but I must've never finished my thought. This is actually a code issue, not a documentation issue. Those route paths should be getting normalized so that the user isn't forced to use one convention or the other. Same as what's done for the config API path here. Sorry about that. I'll file this as an issue and try to get that fixed up ASAP. I'll also gladly accept a PR for this (this time I promise I'll actually get to it right away :P )

@kahmali kahmali mentioned this pull request Jan 20, 2017
@kahmali
Copy link
Owner

kahmali commented Jan 20, 2017

I created an issue to follow up on this, as discussed above. I'm going to go ahead and close this out. Thanks again for reporting the issue!

@kahmali kahmali closed this Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants