Add promise support #266
Add promise support #266
Conversation
|
Not the prettiest way to do it but good enough I think, using it in production as is |
|
Need this feature!!! |
|
@alexgzhou the package is published to atmosphere as |
|
Why is it taking so long to accept it ? The fix doesn't seems that ugly and it is a quite important feature =). |
|
Yeah, this repo seems abandoned too. 6 PRs up in the air so far. |
|
They should grant write access to more people if they can't maintain the project anymore =/ |
|
I'm trying to "rebuild" this project over here: https://github.com/aadamsx/restfine. No more coffee script, refactored to ES6, and now trying to convert the project to npm. Any and all help is appriciated. |
| @@ -57,26 +74,15 @@ class share.Route | |||
| responseData = null | |||
| try | |||
| responseData = self._callEndpoint endpointContext, endpoint | |||
| if responseData instanceof Promise | |||
There was a problem hiding this comment.
I think you can use Promise.resolve to handle with the same syntax the case where the result is a Promise and when it isn't. But of course it works the way you did it ;)
Promise.resolve(responseData).then (result) ->
respond result, {responseInitiated, res}I don't really understand what the try catch block is for though, so maybe I'm wrong.
There was a problem hiding this comment.
is this package about to publish a new version?!!
There was a problem hiding this comment.
You can use lepozepo:restivus, this package doesn't seem to be maintained.
Fixes #208