-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use mini_boost target #177
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 78.90% 78.83% -0.08%
==========================================
Files 202 202
Lines 19632 19632
Branches 8036 8036
==========================================
- Hits 15490 15476 -14
- Misses 4142 4156 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up. The change LGTM. Windows build is failing, but it seems not related to this change. I re-run the Windows build and if it succeeds, we can merge the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is not up-to-date anymore
When I download the latest master branch and try to use Rereading the thread of #170, I think you may expect this PR to include the change proposed in my comment but this is not the case. Should I include it? |
7cb735f
to
e4c2be7
Compare
Rebased to re-trigger the CI. Should be fine to merge when the CI completes |
When you use the
KAHYPAR_DOWNLOAD_BOOST
cmake option without an existing boost installation (what seems to be the intended use case to me), cmake fails afterwards becauseBoost::program_options
is not found.With these changes, this is fixed. As a side effect, the download option now precedes both existing installations and the disable option introduced in #170.