Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mini_boost target #177

Merged
merged 1 commit into from
Aug 29, 2024
Merged

use mini_boost target #177

merged 1 commit into from
Aug 29, 2024

Conversation

juliannz
Copy link
Collaborator

When you use the KAHYPAR_DOWNLOAD_BOOST cmake option without an existing boost installation (what seems to be the intended use case to me), cmake fails afterwards because Boost::program_options is not found.

With these changes, this is fixed. As a side effect, the download option now precedes both existing installations and the disable option introduced in #170.

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d784c91) 78.90% compared to head (7cb735f) 78.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   78.90%   78.83%   -0.08%     
==========================================
  Files         202      202              
  Lines       19632    19632              
  Branches     8036     8036              
==========================================
- Hits        15490    15476      -14     
- Misses       4142     4156      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kittobi1992 kittobi1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up. The change LGTM. Windows build is failing, but it seems not related to this change. I re-run the Windows build and if it succeeds, we can merge the PR.

Copy link
Member

@kittobi1992 kittobi1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not up-to-date anymore

@juliannz
Copy link
Collaborator Author

juliannz commented Aug 22, 2024

When I download the latest master branch and try to use KAHYPAR_DOWNLOAD_BOOST I still run in the same issue and the proposed changes still fix the issue, so did the desired behaviour concerning the precedence of multiple installed versions change in the meantime?
And I didn't find any merge conflicts either...

Rereading the thread of #170, I think you may expect this PR to include the change proposed in my comment but this is not the case. Should I include it?

@N-Maas
Copy link
Collaborator

N-Maas commented Aug 29, 2024

Rebased to re-trigger the CI. Should be fine to merge when the CI completes

@N-Maas N-Maas merged commit 4116131 into master Aug 29, 2024
16 checks passed
@N-Maas N-Maas deleted the julian/use-mini-boost branch October 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants