Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug about localized guide-key/highlight-command-regexp #16

Merged
merged 1 commit into from
Mar 19, 2014

Conversation

aki2o
Copy link
Contributor

@aki2o aki2o commented Feb 24, 2014

The command that is matched by guide-key/highlight-command-regexp was not highlighted even if
the following config was set.

(defun guide-key/my-hook-function-for-org-mode ()
  (guide-key/add-local-guide-key-sequence "C-c")
  (guide-key/add-local-guide-key-sequence "C-c C-x")
  (guide-key/add-local-highlight-command-regexp "org-"))
(add-hook 'org-mode-hook 'guide-key/my-hook-function-for-org-mode)

Then, I found the cause.
guide-key/highlight-command-regexp is a buffer local variable but is read in the guide-key/guide-buffer-name buffer when execute guide-key/popup-function.

So, I've made guide-key/popup-function pass guide-key/highlight-command-regexp to guide-key/get-highlight-face.

Is this trouble a degraded bug?

kai2nenobu pushed a commit that referenced this pull request Mar 19, 2014
fixed bug about localized guide-key/highlight-command-regexp
@kai2nenobu kai2nenobu merged commit b79bc47 into kai2nenobu:master Mar 19, 2014
@kai2nenobu
Copy link
Owner

Thanks a lot.
I made this bug in 2c2d031 by mistake.

@aki2o aki2o deleted the fix-highlight-command branch March 19, 2014 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants