Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: Remove memsize #124

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

2dvorak
Copy link
Contributor

@2dvorak 2dvorak commented Nov 6, 2024

Proposed changes

  • Recent change in go 1.23 is not compatible with go module github.com/fjl/memsize, causing Kaia build to fail in go 1.23
  • This PR removes memsize module from Kaia
  • As a reference, geth also removed memsize because of the same issue (internal/debug: remove memsize ethereum/go-ethereum#30253)

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@2dvorak 2dvorak self-assigned this Nov 6, 2024
@2dvorak 2dvorak marked this pull request as draft November 6, 2024 02:07
@2dvorak 2dvorak marked this pull request as ready for review November 6, 2024 02:44
@blukat29 blukat29 changed the title Remove memsize debug: Remove memsize Nov 6, 2024
@2dvorak 2dvorak merged commit 9ec35a0 into kaiachain:dev Nov 6, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@2dvorak 2dvorak deleted the 2dvorak/remove-memsize branch November 8, 2024 01:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants