-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm: New CallTracer impl and capture more cases in EVM #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
blukat29
requested review from
hyunsooda,
2dvorak,
kjeom,
JayChoi1736,
yoomee1313,
sjnam,
ian0371,
hyeonLewis and
aidan-kwon
as code owners
June 21, 2024 06:09
Account for sender gas fee. Fix the case where tx.to was empty account.
ian0371
previously approved these changes
Jun 24, 2024
hyeonLewis
reviewed
Jun 24, 2024
Co-authored-by: Lewis <lewis.kim@klaytn.foundation>
hyeonLewis
approved these changes
Jun 24, 2024
@yoomee1313 @JayChoi1736 PTAL |
ian0371
approved these changes
Jul 2, 2024
yoomee1313
approved these changes
Jul 2, 2024
2dvorak
approved these changes
Jul 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
callTracer
node/cn/tracers/native
to avoid import cycle.CallFrame
is converted to JSON inGetResult
(for RPC)revertReason
field (ethereum/go-ethereum@ff1f492)gasUsed
field includes intrinsic gas (ethereum/go-ethereum@0f49422)gas
field includes intrinsic gas (ethereum/go-ethereum@0b76eb3)prestateTracer
Types of changes
Please put an x in the boxes related to your change.
Checklist
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments
Notable changes of callTrace
output
field is omitted if empty.value
field is sometimes omitted if it equals zero, but sometimes "0x0" is shown.time
field is deleted.gas
andgasUsed
values agree with transaction and receipts.revertReason
field.reverted.message
field don't need change.value
, to match with EVM semantic.