Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect condition in validate7702 #182

Merged

Conversation

Mdaiki0730
Copy link
Contributor

Proposed changes

validate7702 has been changed to return the appropriate error.
And there are some parts where we've changed whether to return an error or not.

  • Account update does not return err when from does not exist in state
  • Return an error when EOAWithoutCode is "to" in smart contract execution
  • The default is not to return an error.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

kerrors/kerrors.go Outdated Show resolved Hide resolved
Co-authored-by: Yunjong Jeong (ollie) <5933330+blukat29@users.noreply.github.com>
@Mdaiki0730 Mdaiki0730 merged commit 4340fd5 into kaiachain:dev Dec 19, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants