-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kaiax: apply valset module on istanbul consensus #183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoomee1313
force-pushed
the
apply-valset
branch
2 times, most recently
from
December 19, 2024 04:46
d242427
to
5af51ea
Compare
9 tasks
@yoomee1313 #169 is now merged. Please rebase against it (or re-stack your commits after latest |
ian0371
reviewed
Dec 20, 2024
* Changed v.getCouncil(num - 1) to v.getCouncil(num)
yoomee1313
force-pushed
the
apply-valset
branch
from
December 20, 2024 12:22
949620e
to
8bd7f30
Compare
hyeonLewis
reviewed
Dec 22, 2024
yoomee1313
changed the title
[Draft] kaiax: apply valset module
kaiax: apply valset module
Dec 23, 2024
yoomee1313
changed the title
kaiax: apply valset module
kaiax: apply valset module on consensus
Dec 23, 2024
yoomee1313
changed the title
kaiax: apply valset module on consensus
kaiax: apply valset module on istanbul consensus
Dec 23, 2024
Co-authored-by: Chihyun Song <ian0371@gmail.com>
hyeonLewis
reviewed
Dec 23, 2024
ian0371
approved these changes
Dec 23, 2024
blukat29
approved these changes
Dec 23, 2024
@blukat29 @ian0371 @hyeonLewis A commit has been pushed about removeValidatorsFromProposers when remove vote casted. 0ff82f4 (changed to the new commit). Please take a look, thank you. |
yoomee1313
force-pushed
the
apply-valset
branch
from
December 24, 2024 12:52
9ace9dd
to
0ff82f4
Compare
blukat29
approved these changes
Dec 26, 2024
hyeonLewis
approved these changes
Dec 26, 2024
ian0371
reviewed
Dec 26, 2024
ian0371
approved these changes
Dec 26, 2024
blukat29
approved these changes
Dec 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR applies valset module so that it can replace the snapshot validator in consensus.
Main Changes
Validators(proposal Proposal) ValidatorSet
ParentValidators(proposal Proposal) ValidatorSet
GetValidatorSet(num uint64) (*BlockValSet, error)
GetCommitteeSet(num uint64) (*RoundCommitteeState, error)
GetCommitteeStateByRound(num uint64, round uint64) (*RoundCommitteeState, error)
BlockValSet
andRoundCommitteeState
current view (N, Round)
, which is essential for processing consensus messages:valSet istanbul.ValidatorSet
currentCommittee *istanbul.RoundCommitteeState
Points of Interest
Valset.SubList
andValset.SubListWithProposer
have been replaced byRoundCommitteeState.Committee()
.Valset.GetProposer
has been replaced byRoundCommitteeState.Proposer()
.Valset.GetByAddress
has been replaced byBlockValSet.Qualified().At()
.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...