-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support uint256 for rlp, log, hex, vm, abi #233
Conversation
Why is this needed? Doesn't the other txs use uint256? |
What are the other txs? If the other txs isn't But, I think using What is your opinion? Thanks |
I see. I was curious about if type 1 or 2 have already used uint256 fields. IMO, uint256 should be applied for the other txs unless there is huge impact. If it will be done by geth, there is no reason why we don't apply. |
We don't use uint256 for existing transaction types because of need this PR.
It's hard to say whether it has a huge impact or not. I'm making this PR by searching Geth PRs. It's hard to introduce using uint256, and we have to maintain related uint256 after merging this PR.
Geth is using uint256 for txs after blob_tx. The other txs are using bigInt |
Proposed changes
Support uint256 for RLP, Hex, etc. These changes also help to update EIP-7702, which uses uint256
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments