-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Enable EEST blockchainTests #238
base: dev
Are you sure you want to change the base?
Conversation
test: Enable Shanghai and Cancun EIPs blockchain test by Cancun and Prague forks
test: Enable prague's EIP7623
* Enable eip 2935 on blockchain EEST * Fix cyclic import * Fix for lint
test: EETS Set precompile correctly
* Enable old forks other than frontier and byzantium * Restore all old fork tests
* Remove gxhash global variable * Remove unused code
test: Remove some main code modifications in EETS
test: Refactor eets blockchain test flow
Please describe impact to the main logic (IsPrecompiledContractAddress and BeforeApplyMessage). |
@ulbqb I added it to PR's description, please check it! |
@Mdaiki0730 |
That's good. Changed it to new section. |
tests/block_test_util.go
Outdated
return nil | ||
} | ||
|
||
// validateStorage validates storage while considering the difference between Kana and Ethereum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: What is Kana
? Kaia
?
Co-authored-by: Lewis <lewis.kim@kaia.io>
Let's merge it after rc.3. |
Proposed changes
Modify the eest blockchain test flow to run it on all forks (except 2537 and 7702). This time, enable state and storage checks, and comment out header validation.
Test flow
Changes
Impact to the main logic
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...