Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SuggestTipCap default tip cap #44

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Update SuggestTipCap default tip cap #44

merged 3 commits into from
Jul 11, 2024

Conversation

hyeonLewis
Copy link
Contributor

@hyeonLewis hyeonLewis commented Jul 9, 2024

Proposed changes

Now SuggestTipCap has 0 default tip cap. It might return 0 tip even when baseFee > lowerBound when early congestion situation. So we might need to handle this if needed.

64 25 0 	 0,0,0,0,0,0,0,0,0,0,0,0,1,0,0,0,1,0,0,0 	 25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25
65 26 0 	 0,0,0,0,0,0,0,0,0,0,0,1,0,0,0,1,0,0,0,2 	 25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,26
      ^ Network becomes busy, but have 0 tip
66 27 0 	 0,0,0,0,0,0,0,0,0,0,1,0,0,0,1,0,0,0,2,2 	 25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,26,27
67 28 0 	 0,0,0,0,0,0,0,0,0,1,0,0,0,1,0,0,0,2,2,2 	 25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,26,27,28
68 30 0 	 0,0,0,0,0,0,0,0,1,0,0,0,1,0,0,0,2,2,2,2 	 25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,26,27,28,30
69 31 0 	 0,0,0,0,0,0,0,1,0,0,0,1,0,0,0,2,2,2,2,2 	 25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,26,27,28,30,31
70 33 0 	 0,0,0,0,0,0,1,0,0,0,1,0,0,0,2,2,2,2,2,2 	 25,25,25,25,25,25,25,25,25,25,25,25,25,25,25,26,27,28,30,31,33
71 37 2 	 0,0,0,0,0,1,0,0,0,1,0,0,0,2,2,2,2,2,2,2 	 25,25,25,25,25,25,25,25,25,25,25,25,25,25,26,27,28,30,31,33,35
      ^ Tips reflected after having enough txs
72 38 2 	 0,0,0,0,1,0,0,0,1,0,0,0,2,2,2,2,2,2,2,2 	 25,25,25,25,25,25,25,25,25,25,25,25,25,26,27,28,30,31,33,35,36
73 40 2 	 0,0,0,1,0,0,0,1,0,0,0,2,2,2,2,2,2,2,2,2 	 25,25,25,25,25,25,25,25,25,25,25,25,26,27,28,30,31,33,35,36,38
74 42 2 	 0,0,1,0,0,0,1,0,0,0,2,2,2,2,2,2,2,2,2,2 	 25,25,25,25,25,25,25,25,25,25,25,26,27,28,30,31,33,35,36,38,40
75 44 2 	 0,1,0,0,0,1,0,0,0,2,2,2,2,2,2,2,2,2,2,2 	 25,25,25,25,25,25,25,25,25,25,26,27,28,30,31,33,35,36,38,40,42

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Resolve #14 (comment)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@blukat29
Copy link
Contributor

@2dvorak PTAL

@blukat29 blukat29 merged commit 723927c into dev Jul 11, 2024
11 checks passed
@blukat29 blukat29 deleted the tune-suggestTip branch July 11, 2024 13:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA for v1.0.1
3 participants