Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: adjust pebbledb metric #56

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

yoomee1313
Copy link
Contributor

Proposed changes

  • This PR adds some level related pebbledb metrics. Also, it adds PebbleDB dbtype option since it was missing.
  • Some metrics are not matched 100% between leveldb and pebbledb, so be pay attention when comparing those metrics.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

For example, one of the level related pebbledb metric, klaytn_klay_db_chaindata_statetrie_0levelN_size (N=0~6) is now available in pebbleDB.

image

@blukat29
Copy link
Contributor

blukat29 commented Aug 8, 2024

@hyunsooda PTAL

@blukat29 blukat29 mentioned this pull request Aug 8, 2024
4 tasks
@blukat29 blukat29 merged commit 6797a62 into kaiachain:dev Aug 8, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
@yoomee1313 yoomee1313 deleted the add-missing-pebbledb-metric branch November 22, 2024 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants