fix use-after-return

kaijchen · Aug 19, 2024 · 0810403 · 0810403
1 parent fad6250
commit 0810403
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/be/src/runtime/load_stream.cpp b/be/src/runtime/load_stream.cpp
@@ -192,9 +192,12 @@ Status TabletStream::append_data(const PStreamHeader& header, butil::IOBuf* data
  int64_t time_ms = timer.elapsed_time() / 1000 / 1000;
  g_load_stream_flush_wait_ms << time_ms;
  g_load_stream_flush_running_threads << 1;
- auto st = flush_token->submit_func(flush_func);
+ Status st = Status::OK();
  DBUG_EXECUTE_IF("TabletStream.append_data.submit_func_failed",
  { st = Status::InternalError("fault injection"); });
+ if (st.ok()) {
+ st = flush_token->submit_func(add_segment_func);
+ }
  if (!st.ok()) {
  _status = st;
  }
@@ -251,9 +254,12 @@ Status TabletStream::add_segment(const PStreamHeader& header, butil::IOBuf* data
  }
  };
  auto& flush_token = _flush_tokens[new_segid % _flush_tokens.size()];
- auto st = flush_token->submit_func(add_segment_func);
+ Status st = Status::OK();
  DBUG_EXECUTE_IF("TabletStream.add_segment.submit_func_failed",
  { st = Status::InternalError("fault injection"); });
+ if (st.ok()) {
+ st = flush_token->submit_func(add_segment_func);
+ }
  if (!st.ok()) {
  _status = st;
  }