Skip to content

Commit

Permalink
fix compile
Browse files Browse the repository at this point in the history
  • Loading branch information
kaijchen committed Aug 30, 2024
1 parent 9401056 commit 0cdb355
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
15 changes: 10 additions & 5 deletions be/src/runtime/runtime_filter_mgr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,9 @@ Status RuntimeFilterMergeControllerEntity::send_filter_size(const PSendFilterSiz
std::shared_ptr<PBackendService_Stub> stub(
ExecEnv::GetInstance()->brpc_internal_client_cache()->get_client(addr));
if (stub == nullptr) {
LOG(WARNING) << "Failed to init rpc to " << host << ":" << brpc_port;
st = Status::InternalError("Failed to init rpc to {}:{}", host, brpc_port);
LOG(WARNING) << "Failed to init rpc to " << addr.hostname() << ":" << addr.port();
st = Status::InternalError("Failed to init rpc to {}:{}",
addr.hostname(), addr.port());
continue;
}

Expand Down Expand Up @@ -382,6 +383,7 @@ Status RuntimeFilterMergeControllerEntity::merge(const PMergeFilterRequest* requ
int64_t start_merge = MonotonicMillis();
auto filter_id = request->filter_id();
std::map<int, CntlValwithLock>::iterator iter;
Status st = Status::OK();
{
std::shared_lock<std::shared_mutex> guard(_filter_map_mutex);
iter = _filter_map.find(filter_id);
Expand Down Expand Up @@ -440,7 +442,6 @@ Status RuntimeFilterMergeControllerEntity::merge(const PMergeFilterRequest* requ
}

std::vector<TRuntimeFilterTargetParamsV2>& targets = cnt_val->targetv2_info;
Status st = Status::OK();
for (auto& target : targets) {
auto closure = AutoReleaseClosure<PPublishFilterRequestV2,
DummyBrpcCallback<PPublishFilterResponse>>::
Expand All @@ -467,8 +468,12 @@ Status RuntimeFilterMergeControllerEntity::merge(const PMergeFilterRequest* requ
ExecEnv::GetInstance()->brpc_internal_client_cache()->get_client(
target.target_fragment_instance_addr));
if (stub == nullptr) {
LOG(WARNING) << "Failed to init rpc to " << host << ":" << brpc_port;
st = Status::InternalError("Failed to init rpc to {}:{}", host, brpc_port);
LOG(WARNING) << "Failed to init rpc to "
<< target.target_fragment_instance_addr.hostname << ":"
<< target.target_fragment_instance_addr.port;
st = Status::InternalError("Failed to init rpc to {}:{}",
target.target_fragment_instance_addr.hostname,
target.target_fragment_instance_addr.port);
continue;
}
stub->apply_filterv2(closure->cntl_.get(), closure->request_.get(),
Expand Down
3 changes: 2 additions & 1 deletion be/src/vec/sink/load_stream_stub.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ Status LoadStreamStub::open(BrpcClientCache<PBackendService_Stub>* client_cache,
// set connection_group "streaming" to distinguish with non-streaming connections
const auto& stub = client_cache->get_client(node_info.host, node_info.brpc_port);
if (stub == nullptr) {
return Status::InternalError("failed to init brpc client to {}", host_port);
return Status::InternalError("failed to init brpc client to {}:{}", node_info.host,
node_info.brpc_port);
}
stub->open_load_stream(&cntl, &request, &response, nullptr);
for (const auto& resp : response.tablet_schemas()) {
Expand Down

0 comments on commit 0cdb355

Please sign in to comment.