cleanup _is_doing_segcompaction

kaijchen · Aug 26, 2024 · 2b78a3a · 2b78a3a
1 parent 66ccb70
commit 2b78a3a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/be/src/olap/rowset/beta_rowset_writer.cpp b/be/src/olap/rowset/beta_rowset_writer.cpp
@@ -514,11 +514,6 @@ Status BetaRowsetWriter::_rename_compacted_indices(int64_t begin, int64_t end, u
  return Status::OK();
 }
 
-// return true if there is any flying segcompaction, otherwise return false
-bool BetaRowsetWriter::_check_and_set_is_doing_segcompaction() {
- return _is_doing_segcompaction.exchange(true);
-}
-
 Status BetaRowsetWriter::_segcompaction_if_necessary() {
  Status status = Status::OK();
  // if not doing segcompaction, just check segment number
@@ -527,9 +522,9 @@ Status BetaRowsetWriter::_segcompaction_if_necessary() {
  _context.tablet_schema->num_variant_columns() > 0) {
  return _check_segment_number_limit(_num_segment);
  }
- // leave _check_and_set_is_doing_segcompaction as the last condition
+ // leave _is_doing_segcompaction as the last condition
  // otherwise _segcompacting_cond will never get notified
- if (_check_and_set_is_doing_segcompaction()) {
+ if (_is_doing_segcompaction.exchange(true)) {
  return status;
  }
  if (_segcompaction_status.load() != OK) {

diff --git a/be/src/olap/rowset/beta_rowset_writer.h b/be/src/olap/rowset/beta_rowset_writer.h
@@ -307,7 +307,6 @@ class BetaRowsetWriter : public BaseBetaRowsetWriter {
  Status _segcompaction_rename_last_segments();
  Status _load_noncompacted_segment(segment_v2::SegmentSharedPtr& segment, int32_t segment_id);
  Status _find_longest_consecutive_small_segment(SegCompactionCandidatesSharedPtr& segments);
- bool _check_and_set_is_doing_segcompaction();
  Status _rename_compacted_segments(int64_t begin, int64_t end);
  Status _rename_compacted_segment_plain(uint64_t seg_id);
  Status _rename_compacted_indices(int64_t begin, int64_t end, uint64_t seg_id);