[fix](cast) return error when numerical cast out-of-range

kaijchen · Mar 12, 2024 · a9e42da · a9e42da
1 parent b7b3843
commit a9e42da
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/be/src/vec/functions/function_cast.h b/be/src/vec/functions/function_cast.h
@@ -432,6 +432,16 @@ struct ConvertImpl {
  block.get_by_position(result).column =
  ColumnNullable::create(std::move(col_to), std::move(col_null_map_to));
  return Status::OK();
+ } else if constexpr (IsDataTypeNumber<FromDataType> &&
+ IsDataTypeNumber<ToDataType>) {
+ for (size_t i = 0; i < size; ++i) {
+ if (vec_from[i] < min_result || vec_from[i] > max_result) {
+ return Status::InternalError(
+ "Out of range value for column '{}' at row {}",
+ col_to->get_name(), i);
+ }
+ vec_to[i] = static_cast<ToFieldType>(vec_from[i]);
+ }
  } else {
  for (size_t i = 0; i < size; ++i) {
  vec_to[i] = static_cast<ToFieldType>(vec_from[i]);