Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: headings & webpack #74

Closed
wants to merge 2 commits into from
Closed

docs: headings & webpack #74

wants to merge 2 commits into from

Conversation

zalog
Copy link

@zalog zalog commented Apr 3, 2018

The first commit is just a minor glitch.
The second commit adds webpack import.

zalog and others added 2 commits April 3, 2018 11:22
@zalog zalog changed the title docs: repairs headings docs: headings & webpack Apr 3, 2018
@zalog
Copy link
Author

zalog commented Apr 3, 2018

I just saw that we have another PR with that heading fix :)
Please let me know if you need to leave this with webpack only.

@kaimallea
Copy link
Owner

Fixed in #77

@kaimallea kaimallea closed this Nov 12, 2018
@zalog
Copy link
Author

zalog commented Nov 12, 2018

Ok, cool!
I can delete that commit and leave only our import line. It's ok like that?

@kaimallea
Copy link
Owner

@zalog after upgrading, that should do it! let me know if you have any issues!

@zalog
Copy link
Author

zalog commented Nov 16, 2018

Ok. In this PR is another commit with webpack import.
Do we need that in readme file?
16e41b0

I can keep this PR with that single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants