This repository has been archived by the owner on Dec 30, 2021. It is now read-only.
fix(readme.md): change function calls in README.md for imgur v1 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saveClient function expects two arguments and according to the documentation, we were passing only one which resulted in errors. fix kaimallea#162
KenEucker
reviewed
Apr 20, 2021
There was a problem hiding this comment.
This updates the readme and resolves the incorrect instructions for the saveClientId method, with the prototype:
imgur.saveClientId = async (clientId, path) => {
path = path || DEFAULT_CLIENT_ID_PATH;
@kaimallea all good 👍
kaimallea
approved these changes
Apr 20, 2021
|
@swarajpure thanks for your contribution! @KenEucker thx for the extra set of eyes! |
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
saveClient function expects two arguments and according to the documentation, we were passing only
one which resulted in errors.
fix #162