-
Notifications
You must be signed in to change notification settings - Fork 36
fix: configuration -> source is part of system
#500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kairos-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
source is part of system
|
hmmm I guess this should be added as well? This can be part of |
|
|
||
| # Use a different source for the upgrade | ||
| source: "oci:.." | ||
| system: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be recovery-system: https://github.com/kairos-io/kairos-agent/blob/a066e322264ea42e29a3edf5c55eec2e03b4c0ec/pkg/implementations/spec/spec.go#L45-L46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimmykarily thanks for the pointer, tried to update it following the code, but should probably be double checked
|
Also I don't see |
https://github.com/kairos-io/kairos-sdk/blob/60e94acea6e4470f4740db60776235304c4fcf8f/types/install/install.go#L16 |
Thanks! First time I see the sdk. What is the link between the |
The kairos-sdk is where we keep all the code that is re-used by various components (kairos-agent, immucore, kcrypt-challenger, kairos-provider, other providers etc). |
|
Thanks for this fix @jasperdekeuk ! |
Was struggling with the
sourcevariable in cloud-config, but with the logs it seems that it is part ofsystem(?) so updated the docs accordingly