Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to extract files from a docker image last layer #362

Merged
merged 14 commits into from
Sep 10, 2024

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Aug 5, 2024

Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka requested a review from a team August 5, 2024 08:04
@Itxaka Itxaka force-pushed the oci-extract-layer-for-sysext branch from 569b6bd to 0e4d396 Compare August 5, 2024 08:21
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 65.38462% with 18 lines in your changes missing coverage. Please review.

Project coverage is 52.01%. Comparing base (dc46baf) to head (0384b9a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sysext/sysext.go 65.38% 14 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   51.33%   52.01%   +0.68%     
==========================================
  Files          17       18       +1     
  Lines        1315     1367      +52     
==========================================
+ Hits          675      711      +36     
- Misses        531      544      +13     
- Partials      109      112       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itxaka Itxaka force-pushed the oci-extract-layer-for-sysext branch from 0e4d396 to 895144f Compare August 5, 2024 08:28
Itxaka added 2 commits August 5, 2024 10:49
Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka force-pushed the oci-extract-layer-for-sysext branch from 895144f to f1b2d74 Compare August 5, 2024 08:50
@Itxaka
Copy link
Member Author

Itxaka commented Aug 5, 2024

@mudler will this cover this kairos-io/kairos#2631 ?

Still needs work but it currently does what was expected. we should probably expand with tickets on creation of sysexts and such and we need to discuss where to put the command to create those sysexts/confexts as this is only a helper

Itxaka and others added 4 commits September 5, 2024 10:11
Co-authored-by: Mauro Morales <mauro.morales@spectrocloud.com>
Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka force-pushed the oci-extract-layer-for-sysext branch 2 times, most recently from bc44fe4 to 7b6c29a Compare September 10, 2024 07:49
Signed-off-by: Itxaka <itxaka@kairos.io>

	#
@Itxaka Itxaka force-pushed the oci-extract-layer-for-sysext branch from 7b6c29a to 30f3798 Compare September 10, 2024 07:53
Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka merged commit e7f1026 into main Sep 10, 2024
11 checks passed
@Itxaka Itxaka deleted the oci-extract-layer-for-sysext branch September 10, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants