-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring GHW clone and partition type into sdk #492
Conversation
Centralize the Kairos Partition and the methods for getting partitions from the system Signed-off-by: Itxaka <itxaka@kairos.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
+ Coverage 52.01% 53.83% +1.82%
==========================================
Files 18 19 +1
Lines 1367 1551 +184
==========================================
+ Hits 711 835 +124
- Misses 544 587 +43
- Partials 112 129 +17 ☔ View full report in Codecov by Sentry. |
Everything copied from other places right? I assume more PRs will follow up to clean up other repos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it's a copy paste 🤷
mainly yes. There is things like the Still, I need to improve as I would like to store the disk UUID so we can identify the disk by the UUID directly (remember the kairos disk predictable uuid?) which can come in handy in the future. |
ah yes, there is also an improvements in the Partition struct as we now store the type of FS and the UUID (again, improvements for the future in identifying the disk via a constant uuid :D) |
Signed-off-by: Itxaka <itxaka@kairos.io>
- Get a logger instance - Allow setting trace level from env vars - log a LOT of stuff - Remove uneeded Type filed. It already has FS for the same - Fix Paths appending with optional prefix - Allow Calling GetDisks with nil logger. It will create its own. - Get disk size and uuid - log on errors Signed-off-by: Itxaka <itxaka@kairos.io>
Centralize the Kairos Partition and the methods for getting partitions from the system