Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the ghw paths on ghw mock #496

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Override the ghw paths on ghw mock #496

merged 2 commits into from
Sep 17, 2024

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Sep 17, 2024

When mocking the ghw stuff, we need to set the proper env var so the normal ghw scan looks at our mocked path instead.

On clean, we unset the var

This is so when using the mock, the ghw clone will pick up the env var and automatically set the paths pointing to it. This is useful for testing and was present on ghw as well, but now we can directly use it on our mock object so its done for us automatically

When mocking the ghw stuff, we need to set the proper env var so the
normal ghw scan looks at our mocked path instead.

On clean, we unset the var

Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka requested a review from a team September 17, 2024 10:27
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.04%. Comparing base (64886b7) to head (b1ec6cc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   53.65%   54.04%   +0.38%     
==========================================
  Files          19       19              
  Lines        1558     1558              
==========================================
+ Hits          836      842       +6     
+ Misses        592      587       -5     
+ Partials      130      129       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We dont want to marshall/unmarshall it if its empty

Signed-off-by: Itxaka <itxaka@kairos.io>
@Itxaka Itxaka merged commit ae2e2d7 into main Sep 17, 2024
13 checks passed
@Itxaka Itxaka deleted the mock_cleanup branch September 17, 2024 11:10
renovate bot referenced this pull request in kairos-io/provider-kairos Sep 18, 2024
)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/kairos-io/kairos-sdk](https://redirect.github.com/kairos-io/kairos-sdk)
| `v0.4.4` -> `v0.4.5` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fkairos-io%2fkairos-sdk/v0.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fkairos-io%2fkairos-sdk/v0.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fkairos-io%2fkairos-sdk/v0.4.4/v0.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fkairos-io%2fkairos-sdk/v0.4.4/v0.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>kairos-io/kairos-sdk
(github.com/kairos-io/kairos-sdk)</summary>

###
[`v0.4.5`](https://redirect.github.com/kairos-io/kairos-sdk/releases/tag/v0.4.5)

[Compare
Source](https://redirect.github.com/kairos-io/kairos-sdk/compare/v0.4.4...v0.4.5)

#### What's Changed

- Override the ghw paths on ghw mock by
[@&#8203;Itxaka](https://redirect.github.com/Itxaka) in
[https://github.com/kairos-io/kairos-sdk/pull/496](https://redirect.github.com/kairos-io/kairos-sdk/pull/496)

**Full Changelog**:
kairos-io/kairos-sdk@v0.4.4...v0.4.5

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant