Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use formatting print to show underlying error message #500

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

kruton
Copy link
Contributor

@kruton kruton commented Sep 19, 2024

This appears to be a typo where "Println" was used instead of "Printf"

This appears to be a typo where "Println" was used instead of "Printf"

Signed-off-by: Kenny Root <kenny@the-b.org>
Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

collector/collector.go Outdated Show resolved Hide resolved
@mudler mudler enabled auto-merge (squash) September 27, 2024 07:53
collector/collector.go Outdated Show resolved Hide resolved
collector/collector.go Outdated Show resolved Hide resolved
collector/collector.go Outdated Show resolved Hide resolved
@mudler mudler merged commit 9b2eeb0 into kairos-io:main Sep 27, 2024
8 of 9 checks passed
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.30%. Comparing base (541728f) to head (ddcaef0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
collector/collector.go 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   54.40%   54.30%   -0.11%     
==========================================
  Files          19       19              
  Lines        1566     1569       +3     
==========================================
  Hits          852      852              
- Misses        586      587       +1     
- Partials      128      130       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kruton kruton deleted the patch-1 branch September 27, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants