Move to use kairos-release instead of os-release #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itxaka <itxaka@kairos.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=======================================
Coverage 54.30% 54.30%
=======================================
Files 19 19
Lines 1569 1569
=======================================
Hits 852 852
Misses 587 587
Partials 130 130 ☔ View full report in Codecov by Sentry. |
mauromorales
approved these changes
Oct 1, 2024
jimmykarily
reviewed
Oct 2, 2024
| kairosKey = "KAIROS_" + key | ||
| v, exists = release[kairosKey] | ||
| if !exists { | ||
| // We try with the old naming without the prefix in case the key wasn't found |
There was a problem hiding this comment.
It's been a long time since we introduced the prefix. What is this trying to catch?
There was a problem hiding this comment.
really old releases upgrading to newer ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of kairos-io/kairos#2907