Read the first ten lines of a config to check for headers #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There could be comments before the cloud-config header or jinja expressions as we found already[0] so our current header check its a bit strict. This patch makes it so er read the first ten lines of the config source, check for # at the start and then check for the headers as we did before, so we are a bit more letinent in case the cloud-config header is not the first thing in the file Signed-off-by: Itxaka <itxaka@kairos.io>
jimmykarily
reviewed
Sep 15, 2023
jimmykarily
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be comments before the cloud-config header or jinja expressions as we found already[0] so our current header check its a bit strict.
This patch makes it so er read the first ten lines of the config source, check for # at the start and then check for the headers as we did before, so we are a bit more letinent in case the cloud-config header is not the first thing in the file
Fixes: kairos-io/kairos#1714