Allow passing readers to collector #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm assuming you plan to use this here: https://github.com/kairos-io/kairos-agent/pull/150/files . Can you change that PR to use this one so it's clear how this is meant to be used? |
This makes it possible to pass a series of readers to collector so when we scan we get those readers read and merged into the config as if they were files. This allows a bit more of flexibility in what the collector consumes as it makes it possible to receive configs from a different source than a file and make them part of the final object Signed-off-by: Itxaka <itxaka@kairos.io>
Itxaka
force-pushed
the
collector_reader
branch
from
89ca34d
to
ac348c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 45.90% 46.59% +0.68%
==========================================
Files 12 12
Lines 854 880 +26
==========================================
+ Hits 392 410 +18
- Misses 400 406 +6
- Partials 62 64 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jimmykarily
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to pass a series of readers to collector so when
we scan we get those readers read and merged into the config as if they
were files.
This allows a bit more of flexibility in what the collector consumes as
it makes it possible to receive configs from a different source than a
file and make them part of the final object
Signed-off-by: Itxaka itxaka@kairos.io