Fix install.device schema to allow all devices #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. /dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:0:0 Part of kairos-io/kairos#2906 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
commented
Nov 7, 2024
| @@ -4,7 +4,7 @@ go 1.23.1 | |||
|
|
|||
| require ( | |||
| github.com/avast/retry-go v2.7.0+incompatible | |||
| github.com/containerd/containerd/v2 v2.0.0 | |||
| github.com/containerd/containerd v1.7.23 | |||
There was a problem hiding this comment.
I only run go mod tidy . I don't know why this happens 🤷
jimmykarily
commented
Nov 7, 2024
| @@ -11,7 +11,7 @@ type InstallSchema struct { | |||
| BindMounts []string `json:"bind_mounts,omitempty"` | |||
| Bundles []BundleSchema `json:"bundles,omitempty" description:"Add bundles in runtime"` | |||
| NoFormat bool `json:"no_format,omitempty"` | |||
| Device string `json:"device,omitempty" pattern:"^(auto|/|(/[a-zA-Z0-9_-]+)+)$" description:"Device for automated installs" examples:"[\"auto\",\"/dev/sda\"]"` | |||
| Device string `json:"device,omitempty" pattern:"^(auto|/dev/.+)$" description:"Device for automated installs" examples:"[\"auto\",\"/dev/sda\"]"` | |||
There was a problem hiding this comment.
It doesn't seem to work with escaped slashes \/ but it works like this so... 🤷
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
=======================================
Coverage 53.11% 53.11%
=======================================
Files 19 19
Lines 1973 1973
=======================================
Hits 1048 1048
Misses 795 795
Partials 130 130 ☔ View full report in Codecov by Sentry. |
Itxaka
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. /dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:0:0
Part of kairos-io/kairos#2906