Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove variant from base tag #60

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

mauromorales
Copy link
Member

My bad, when I originally added the base-image function to naming.sh I included this bug, I have already fixed it on naming.sh so here is the PR to keep them in sync

@mauromorales mauromorales self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (29fc485) 50.45% compared to head (262e352) 50.45%.

Files Patch % Lines
versioneer/versioneer.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   50.45%   50.45%   -0.01%     
==========================================
  Files          16       16              
  Lines        1306     1312       +6     
==========================================
+ Hits          659      662       +3     
- Misses        551      553       +2     
- Partials       96       97       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauromorales mauromorales merged commit 5a07888 into main Dec 7, 2023
2 of 4 checks passed
@mauromorales mauromorales deleted the remove-variant-from-base-tag branch December 7, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants