Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require "Variant" to be set when generating base container names #65

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

jimmykarily
Copy link
Contributor

Part of: kairos-io/kairos#2104

(Needs to be bumped in kairos-agent to complete the story)

Part of: kairos-io/kairos#2104

(Needs to be bumped in kairos-agent to complete the story)

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
@jimmykarily jimmykarily requested a review from a team January 4, 2024 14:49
@jimmykarily jimmykarily self-assigned this Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eaa9d3c) 52.06% compared to head (6b80cac) 52.12%.

Files Patch % Lines
versioneer/versioneer.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   52.06%   52.12%   +0.06%     
==========================================
  Files          16       16              
  Lines        1383     1385       +2     
==========================================
+ Hits          720      722       +2     
  Misses        567      567              
  Partials       96       96              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jimmykarily jimmykarily merged commit e671e8d into main Jan 5, 2024
4 checks passed
@jimmykarily jimmykarily deleted the 2104-dont-require-variant-in-base-names branch January 5, 2024 08:18
jimmykarily added a commit to kairos-io/kairos-agent that referenced this pull request Jan 5, 2024
to consume kairos-io/kairos-sdk#65

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
renovate bot referenced this pull request in kairos-io/provider-kairos Jan 6, 2024
…517)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/kairos-io/kairos-sdk](https://togithub.com/kairos-io/kairos-sdk)
| `v0.0.21` -> `v0.0.22` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fkairos-io%2fkairos-sdk/v0.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fkairos-io%2fkairos-sdk/v0.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fkairos-io%2fkairos-sdk/v0.0.21/v0.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fkairos-io%2fkairos-sdk/v0.0.21/v0.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>kairos-io/kairos-sdk
(github.com/kairos-io/kairos-sdk)</summary>

###
[`v0.0.22`](https://togithub.com/kairos-io/kairos-sdk/releases/tag/v0.0.22)

[Compare
Source](https://togithub.com/kairos-io/kairos-sdk/compare/v0.0.21...v0.0.22)

#### What's Changed

- Don't require "Variant" to be set when generating base container names
by [@&#8203;jimmykarily](https://togithub.com/jimmykarily) in
[https://github.com/kairos-io/kairos-sdk/pull/65](https://togithub.com/kairos-io/kairos-sdk/pull/65)

**Full Changelog**:
kairos-io/kairos-sdk@v0.0.21...v0.0.22

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants