-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require "Variant" to be set when generating base container names #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of: kairos-io/kairos#2104 (Needs to be bumped in kairos-agent to complete the story) Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 52.06% 52.12% +0.06%
==========================================
Files 16 16
Lines 1383 1385 +2
==========================================
+ Hits 720 722 +2
Misses 567 567
Partials 96 96 ☔ View full report in Codecov by Sentry. |
mauromorales
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jimmykarily
added a commit
to kairos-io/kairos-agent
that referenced
this pull request
Jan 5, 2024
to consume kairos-io/kairos-sdk#65 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
renovate bot
referenced
this pull request
in kairos-io/provider-kairos
Jan 6, 2024
…517) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/kairos-io/kairos-sdk](https://togithub.com/kairos-io/kairos-sdk) | `v0.0.21` -> `v0.0.22` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fkairos-io%2fkairos-sdk/v0.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fkairos-io%2fkairos-sdk/v0.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fkairos-io%2fkairos-sdk/v0.0.21/v0.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fkairos-io%2fkairos-sdk/v0.0.21/v0.0.22?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kairos-io/kairos-sdk (github.com/kairos-io/kairos-sdk)</summary> ### [`v0.0.22`](https://togithub.com/kairos-io/kairos-sdk/releases/tag/v0.0.22) [Compare Source](https://togithub.com/kairos-io/kairos-sdk/compare/v0.0.21...v0.0.22) #### What's Changed - Don't require "Variant" to be set when generating base container names by [@​jimmykarily](https://togithub.com/jimmykarily) in [https://github.com/kairos-io/kairos-sdk/pull/65](https://togithub.com/kairos-io/kairos-sdk/pull/65) **Full Changelog**: kairos-io/kairos-sdk@v0.0.21...v0.0.22 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: kairos-io/kairos#2104
(Needs to be bumped in kairos-agent to complete the story)