Skip to content

Commit

Permalink
Address yaml warnings
Browse files Browse the repository at this point in the history
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
  • Loading branch information
mauromorales committed Jun 24, 2024
1 parent e2e0331 commit 07ac0cd
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 19 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/image-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,18 +174,18 @@ jobs:
flavor: ubuntu
flavor_release: "24.04"
family: "ubuntu"
release_matcher: "23.10" # introduced so tests can be green while we wait for the kairos release with the latest flavor release
release_matcher: "23.10" # introduced so tests can be green while we wait for the kairos release with the latest flavor release
needs:
- core-ubuntu-24-lts

# enable once the first alpine only release is out as it currently cannot find the latest alpine release properly
#upgrade-latest-alpine:
# uses: ./.github/workflows/reusable-upgrade-latest-test.yaml
# with:
# flavor: alpine
# flavor_release: "3.19"
# needs:
# - core-alpine
# upgrade-latest-alpine:
# uses: ./.github/workflows/reusable-upgrade-latest-test.yaml
# with:
# flavor: alpine
# flavor_release: "3.19"
# needs:
# - core-alpine

custom-partitioning:
uses: ./.github/workflows/reusable-custom-partitioning-test.yaml
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
fail-fast: false
matrix:
include:
- flavor: opensuse # Kubo test needs systemd version 252+ which atm is not available in Leap
- flavor: opensuse # Kubo test needs systemd version 252+ which atm is not available in Leap
flavorRelease: tumbleweed
reset:
uses: ./.github/workflows/reusable-qemu-reset-test.yaml
Expand Down Expand Up @@ -216,16 +216,16 @@ jobs:
flavor: ${{ matrix.flavor }}
flavor_release: ${{ matrix.flavorRelease }}
family: ${{ matrix.family }}
release_matcher: ${{ matrix.releaseMatcher }} # introduced so tests can be green while we wait for the kairos release with the latest flavor release
release_matcher: ${{ matrix.releaseMatcher }} # introduced so tests can be green while we wait for the kairos release with the latest flavor release
needs:
- core
strategy:
fail-fast: false
matrix:
include:
# cant do alpine yet as it hasnt been released with the proper name
#- flavor: alpine
# flavorRelease: "3.19"
# - flavor: alpine
# flavorRelease: "3.19"
- flavor: opensuse
flavorRelease: leap-15.6
family: opensuse
Expand Down Expand Up @@ -331,21 +331,21 @@ jobs:
flavor: ${{ matrix.flavor }}
flavor_release: ${{ matrix.flavorRelease }}
family: ${{ matrix.family }}
release_matcher: ${{ matrix.releaseMatcher }} # introduced so tests can be green while we wait for the kairos release with the latest flavor release
release_matcher: ${{ matrix.releaseMatcher }} # introduced so tests can be green while we wait for the kairos release with the latest flavor release
needs:
- standard
strategy:
fail-fast: false
max-parallel: 2
matrix:
include:
# cant do alpine yet as it hasnt been released with the proper name
# - flavor: "alpine"
# flavorRelease: "3.19"
- flavor: "opensuse"
flavorRelease: "leap-15.6"
family: "opensuse"
releaseMatcher: "leap-15.5"
# cant do alpine yet as it hasnt been released with the proper name
#- flavor: "alpine"
# flavorRelease: "3.19"
notify:
runs-on: ubuntu-latest
if: failure()
Expand Down
4 changes: 2 additions & 2 deletions .yamllint
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ extends: default
rules:
# 80 chars should be enough, but don't fail if a line is longer
line-length:
max: 150
max: 305
level: warning

# accept both key:
Expand All @@ -18,4 +18,4 @@ rules:
check-keys: false

document-start:
present: false
present: false
2 changes: 1 addition & 1 deletion Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ shellcheck-lint:
FROM koalaman/shellcheck-alpine:$SHELLCHECK_VERSION
WORKDIR /mnt
COPY . .
RUN find . -name "*.sh" -print | xargs -r -n1 shellcheck
RUN find . -name "*.sh" ! -path "./examples/*" -print | xargs -r -n1 shellcheck

yamllint:
FROM cytopia/yamllint
Expand Down

0 comments on commit 07ac0cd

Please sign in to comment.