Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kairos dockerfiles should create full kairos images #1897

Closed
3 of 5 tasks
jimmykarily opened this issue Oct 9, 2023 · 2 comments · Fixed by #2008
Closed
3 of 5 tasks

Kairos dockerfiles should create full kairos images #1897

jimmykarily opened this issue Oct 9, 2023 · 2 comments · Fixed by #2008
Assignees
@mauromorales

Comments

@jimmykarily
Copy link
Contributor

jimmykarily commented Oct 9, 2023 •
edited by mauromorales
Loading

Currently, we build the Dockerfiles, and then we do many more things in Earthly.

All this logic can be moved to the Dockerfiles. This will allow the creation of other derivatives without any Earthly knowledge.

Items extracted from TODOs (#1912):

  • Merge Alma, Rocky and Fedora to one family Dockerfile
  • Move rest of logic from Earthfile to Dockerfiles
  • Create a reusable workflow that simply calls docker build, passing the required build-args
  • Delete the earthly base-image target and force the use of the above workflow anywhere needed
  • Make all remaining earthly targets to use a pre-cooked KAIROS_IMAGE rather than calling +base-image
@jimmykarily jimmykarily converted this from a draft issue Oct 9, 2023
@mauromorales mauromorales moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Oct 9, 2023
@mauromorales mauromorales moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board Oct 9, 2023
@jimmykarily
Copy link
Contributor Author

Better merge this first: #1939

@jimmykarily jimmykarily mentioned this issue Oct 24, 2023
Merged
jimmykarily added a commit that referenced this issue Oct 24, 2023
@jimmykarily
Remove TODOs
611e184 
moved here: #1897 (comment)

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily added a commit that referenced this issue Oct 24, 2023
@jimmykarily
Remove TODOs
afff956 
moved here: #1897 (comment)

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily added a commit that referenced this issue Oct 24, 2023
@jimmykarily
Remove TODOs
2b9c943 
moved here: #1897 (comment)

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily added a commit that referenced this issue Oct 24, 2023
@jimmykarily @mauromorales
1898 byoi (#1912)
664c96f 
* Refactor flavors and dockerfiles

Fixes #1898

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Use FRAMEWORK_FLAVOR variable to avoid confusion with FLAVOR

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Fix pipeline by adding mandatory value

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Fix ubuntu Dockerfile

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Apply suggestions from code review

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Remove TODO (already implemented) and non-used ARG "IMAGE"

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Remove TODOs

moved here: #1897 (comment)

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Remove unecessary env variables and fix VARIANT_RELEASE missing

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* PR comments

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Remove naming.sh script from base image

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Make sure we use the "fixed" kairos version with the remove "+" symbols

when creating a tag for container images.

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Setup qemu and docker buildx in reusable-build-flavor workflow

because otherwise it fails to build rpi images

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Remove not needed env variables

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Remove temporary change

Signed-off-by: Dimitris Karakasilis <jimmykarily@gmail.com>

---------

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <jimmykarily@gmail.com>
Co-authored-by: Mauro Morales <mauro.morales@spectrocloud.com>
This was referenced Oct 30, 2023
Closed
Closed
@mauromorales mauromorales moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Nov 8, 2023
@mauromorales mauromorales self-assigned this Nov 8, 2023
@mauromorales
Copy link
Member

I will better not merge since it makes it less explicit for some of the actions in which distro they should be run and in which not

@mauromorales mauromorales removed their assignment Nov 13, 2023
@mauromorales mauromorales moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board Nov 13, 2023
@mauromorales mauromorales moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Nov 14, 2023
@mauromorales mauromorales self-assigned this Nov 14, 2023
@mauromorales mauromorales mentioned this issue Nov 16, 2023
Merged
@mauromorales mauromorales mentioned this issue Nov 24, 2023
Merged
This was referenced Nov 27, 2023
Closed
Closed
Open
@github-project-automation github-project-automation bot moved this from In Progress 🏃 to Done ✅ in 🧙Issue tracking board Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauromorales mauromorales

Labels
None yet
Projects
🧙Issue tracking board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Move Earthly logic into Dockerfiles kairos-io/kairos
2 participants
@mauromorales @jimmykarily