-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge opnesuse families into one #1957
Conversation
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
8a597a7
to
43a9a06
Compare
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we even need the family anymore?
Let me expand on this. It seems that with this patch, the family and the flavor are the same in all but the nvidia board, and Im not even sure that needs a specific family when it has the model stuff no? And in fact it should be of the same family as the ubuntu, just it will have a different path I guess...
@Itxaka IMO we still need the family, first because it lets us merge distros like fedora, alma and rocky into a rhel family. Second because it allows the community to try Kairosifying other distros we don't really support, for example if you use Linux Mint or elementary as your base image, you can use the Ubuntu family, if you have PostmarketOS as your base image you can use the alpine family. |
for the nvidia one, indeed it could be part of Ubuntu, we just felt that this is so unique and probably will not change often, so it was more at risk of braking if merged with the Ubuntu dockerfile. Specially because for the orin it only works with one version of ubuntu even. |
Thanks for the explanation! |
No description provided.