Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add n-gon support #12

Closed
kaisalmen opened this issue Aug 2, 2017 · 3 comments
Closed

Add n-gon support #12

kaisalmen opened this issue Aug 2, 2017 · 3 comments
Assignees
@kaisalmen
Labels
enhancement

Comments

@kaisalmen
Copy link
Owner

kaisalmen commented Aug 2, 2017 •
edited
Loading

OBJLaoder2 does not support n-gon. Feature should be added.
@kaisalmen kaisalmen self-assigned this Aug 2, 2017
@kaisalmen kaisalmen changed the title Add ngon support Add n-gon support Aug 2, 2017
@kaisalmen kaisalmen mentioned this issue Aug 2, 2017
Merged
@jonnenauha
Copy link

@kaisalmen what source files and functions should people start looking at, if they want to help out on this? Can you give an high level overview what this would involve.

@kaisalmen
Copy link
Owner Author

Start here: parseArrayBuffer:
https://github.com/kaisalmen/WWOBJLoader/blob/master/src/loaders/OBJLoader2.js#LL258-LL299
processLine:
https://github.com/kaisalmen/WWOBJLoader/blob/master/src/loaders/OBJLoader2.js#LL387-LL429
and from there further down.

This is designed with triangle and quads in mind and processing must be rethought for n-gons.

More to come

kaisalmen added a commit that referenced this issue Aug 11, 2017
@kaisalmen
#12 First version of n-gon support
5277dae
kaisalmen added a commit that referenced this issue Aug 11, 2017
@kaisalmen
#12 Simplification, moved complex logic to RawObject. Performance is …
806f4cf 
…good
@kaisalmen
Copy link
Owner Author

Adopted solution from three.js #11871.
Performance is no impacted.
Simplified code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaisalmen kaisalmen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonnenauha @kaisalmen