Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isDisabled is, well, disabled. #23

Closed
jackbackes opened this issue Dec 21, 2016 · 0 comments · Fixed by #24
Closed

isDisabled is, well, disabled. #23

jackbackes opened this issue Dec 21, 2016 · 0 comments · Fixed by #24

Comments

@jackbackes
Copy link
Contributor

The src for RIEBase has the prop isDisabled, but it is currently no-op. The expected functionality would be to prevent firing startEditing, or somehow prevent switching to the editing: true state. I believe this could be accomplished by adding a single line to the startEditing method:
if(this.props.isDisabled) return;
@jackbackes jackbackes mentioned this issue Dec 21, 2016
Merged
osteele added a commit to osteele/signage that referenced this issue Apr 15, 2017
@osteele
When signed out, hide app list Add Item, delete icon
c70f50d 
The app titles and URLs still appear editable (although changes are not
written to Firebase), because kaivi/riek#23
@kaivi kaivi closed this as completed in #24 Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE-23[isDisabled]: enables the isDisabled prop jackbackes/riek
1 participant
@jackbackes