Improve colors #198
Merged
Improve colors #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channels given as e.g. `r g b/a` are now converted to proper `r, g, b, a` format.
kaj
force-pushed
the
improve-colors
branch
6 times, most recently
from
f61813a to
0284bcd
Compare
kaj
added a commit
that referenced
this pull request
Feb 2, 2025
Released 2025-02-02. Progress: 5879 of 12589 tests passed. The large number of new failing tests are mainly for new color functions that rsass don't support yet. ### Breaking changes: * Replaced the css `Selector` implementation. The new "logical" selector types that was used in selector function in rsass 0.28 is now the only css selector implementation. Most of the api to those types are private. Some will probably be made public after some stabilization period. * The `Debug` trait for `Error` is now the standard derived impl, to get the pretty output, use the `Display` trait. * All numbers are now represented as f64 (#203). This removes integration with `num-rational`, `num-bigint`, `num-integer` and `num-traits`. * Improved `@for` loop evaluation and error handling (#206). * Msrv is now 1.65.0 for rsass (and 1.74 for rsass-cli). ### Other changes: * Lots of color handling. - Spec changes for traditional css colors (PR #198). - Made all color channels f64 instead of Rational (PR #199). * Fixed a bug where `clamp(..)` was sometimes evaluated to a value even though units wasn't comparable. * Improved parse error handling (Issue #141, PR #201, PR #205). Many parse errors now match the dart sass error message. Also allow "loud" comments in more places. * Pure css `round()` may take an expression argument. * Minor changes in agrument syntax errors. * Updated `nom` to 8.0.0 and added `nom-language` 0.1.0. * Updated sass-spec test suite to 2025-01-29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec test suite has updated with a lot of changes in how colors should behave.
These changes fixes most changed requirements of traditional colors, while ignoring partial colors and everything regarding explicit color spaces.