Keywords Fix and Refactoring #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this contribution! It looks good at a quick glance, but it's a lot of changes to read through, so it will take me some time before I merge it. |
kaj
approved these changes
May 8, 2019
kaj
added a commit
that referenced
this pull request
Feb 7, 2022
* Merge PR #7 from @hummingly: - Updates dependencies. - Fixes a bug where adding keywords would just overwrite/add the Subject entry. - Changes create_X functions to constructors that are only visible in the crate. - Improves allocations: removed a few clones, allocate space before inserting elements etc. - Puts graphicsstates tests into test module which removes dead code warning. - Overall made more use of the standard library. * Add keyword "pdf" to crate, PR #6 from @adiba * Update to Rust edition 2021. * Update `lazy_static` dependency. * Use `chrono` 0.4.19 instead of `time` 0.1. * Update travis build to use more up to date rust versions and stable rustfmt. * Update clippy directive. * Some rustfmt updates. Thanks to @hummingly and @adiba!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clones, allocate space before inserting elements etc.graphicsstates tests into test module which removes dead code warning.