Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing Python package clobbers installed Pytorch #10

Closed
cynthia opened this issue Dec 5, 2018 · 2 comments
Closed

Installing Python package clobbers installed Pytorch #10

cynthia opened this issue Dec 5, 2018 · 2 comments
Milestone

Comments

@cynthia
Copy link
Contributor

cynthia commented Dec 5, 2018

As I understand the build process, it seems like the Python bindings do not necessarily have to depend on Pytorch, as it's used only for building the resources.

At the moment installing through setup.py clobbers the current environment's installed Pytorch to 0.4.1, which seems like a dealbreaker for anyone who wants to use this package as part of their analytics pipeline, who also uses Pytorch. (which, most likely is going to be a more recent version)

It feels like there are two ways forward for this:

  1. Only require Pytorch for the build process, remove dependency from bindings and possibly make the resource builder another package that does depend on it. (this would allow users to split environments, which is suboptimal but worse than overwriting the installed version)
  2. Respect and try to make use of whatever Pytorch version the user has.

2 seems like a bumpy road forward considering the stability of the API. Another option would be to have pre-built models as downloadable static resources so users don't have to deal with the resource building process - it does feel like something only seasoned users would be interested in.

@krikit
Copy link
Member

krikit commented Dec 5, 2018

Thanks for your good proposal. Actually the model parameters are not necessary to be compiled every time. We will consider removing PyTorch dependency from dictionary compile process.

@cynthia
Copy link
Contributor Author

cynthia commented Dec 5, 2018

I think having the pre-trained models downloadable as static resources somewhere would be ideal, a lot of frameworks do this by sticking datasets and pretrained models on say S3. Since there is a cost factor here, I'm curious if you can put it on say, http://mirror.kakao.com as an alternative solution.

(The one downside is that that site doesn't seem to support H2 or TLS, so it could be considered rather insecure.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants