Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack 주소 및 가입 페이지 안내 문구 추가 #31 #32

Merged
merged 2 commits into from
Dec 17, 2018

Conversation

krikit
Copy link
Member

@krikit krikit commented Dec 17, 2018

설명 (Description)

  • 슬랙 페이지와 자동 가입 페이지에 대한 안내 문구를 readme에 추가했습니다.

개발자를 위한 가이드 (Developer's Guide)

만약 khaiii에 pull request가 처음이라면 개발자를 위한 가이드 문서들을 한번 읽어보시길 권고드립니다.

If this is your first pull request for khaiii, please see the Developer's Guide.

체크 리스트 (Checklist)

pull request 전에 아래 체크 리스트들을 만족하는 지 확인한 후 체크('x') 표시를 해주시기 바랍니다.

Before you submit pull requests, please check(set 'x') to the checklist below.

  • master 브랜치가 아니라 develop 브랜치에 머지하도록 pull request를 작성 중이신가요? (Did you merge into develop branch not master?)
  • build/test/khaiii 프로그램을 실행하여 테스트가 성공했나요? (Did all tests are passed when you ran as build/test/khaiii)
  • PyLint 툴을 실행하여 발생한 에러를 모두 수정하셨나요? (Did you fix all errors after running PyLint?)
  • CppLint 툴을 실행하여 발생한 에러를 모두 수정하셨나요? (Did you fix all errors after running CppLint?)

@hubert-lee hubert-lee merged commit a99a719 into develop Dec 17, 2018
@hubert-lee hubert-lee deleted the feature/31 branch December 17, 2018 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants