Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only RPC calls for integration tests. #74

Open
ijsong opened this issue Aug 25, 2022 · 0 comments
Open

Use only RPC calls for integration tests. #74

ijsong opened this issue Aug 25, 2022 · 0 comments

Comments

@ijsong
Copy link
Member

ijsong commented Aug 25, 2022 •
edited
Loading

One of the integration tests - `TestSealLogStreamSealedIncompletely uses a method of admin server directly. It is not suitable for integration tests. Instead, we should use RPC calls.

The method is internal/admin.(*Admin).Metadata().
ijsong added a commit that referenced this issue Aug 25, 2022
@ijsong
style: resolve lint warnings - staticcheck
b4d1f32 
It skips lint warnings related to #73, #74, and #75.
@ijsong ijsong mentioned this issue Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ijsong