Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client,storagenode): remove Head and Tail from proto/varlogpb.(LogStreamDescriptor) #261

Merged

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Dec 9, 2022

What this PR does

This patch removes deprecated fields - proto/varlogpb.(LogStreamDescriptor).Head and
proto/varlogpb.(LogStreamDescriptor).Tail. It also removes deprecated APIs -
pkg/varlog.(Log).LogStreamMetadata and pkg/varlog.(Log).LogStreamReplicaMetadata.

Which issue(s) this PR resolves

Resolves #73

@ijsong ijsong self-assigned this Dec 9, 2022
…ogStreamDescriptor)

This patch removes deprecated fields - `proto/varlogpb.(LogStreamDescriptor).Head` and
`proto/varlogpb.(LogStreamDescriptor).Tail`. It also removes deprecated APIs -
`pkg/varlog.(Log).LogStreamMetadata` and `pkg/varlog.(Log).LogStreamReplicaMetadata`.

Resolves #73
@ijsong ijsong force-pushed the remove-head-tail-from-logstreamdescriptor branch from a8caa18 to 57161c8 Compare December 9, 2022 11:33
@ijsong ijsong changed the title refactor(client,storagenode): remove Head and Tail from proto/varlogpb.(LogStreamDescriptor) feat(client,storagenode): remove Head and Tail from proto/varlogpb.(LogStreamDescriptor) Dec 9, 2022
@ijsong ijsong marked this pull request as ready for review December 9, 2022 12:20
@ijsong ijsong requested a review from hungryjang as a code owner December 9, 2022 12:20
@ijsong ijsong merged commit 6f36b0d into kakao:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields Head and Tail of proto/varlogpb.(LogStreamDescriptor) are deprecated.
1 participant