Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(varlogtest): support ListLogStreams API #607

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Oct 10, 2023

What this PR does

This PR implements ListLogStreams for the varlogtest package.

This PR implements ListLogStreams for the varlogtest package.
@ijsong
Copy link
Member Author

ijsong commented Oct 10, 2023

@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (b6ab649) 61.23% compared to head (c0c2e9d) 61.08%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           rename_logstreamreplicas     #607      +/-   ##
============================================================
- Coverage                     61.23%   61.08%   -0.15%     
============================================================
  Files                           144      144              
  Lines                         19185    19199      +14     
============================================================
- Hits                          11747    11727      -20     
- Misses                         6853     6879      +26     
- Partials                        585      593       +8     
Files Coverage Δ
pkg/varlogtest/admin.go 47.95% <67.85%> (+0.06%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong
Copy link
Member Author

ijsong commented Oct 10, 2023

Merge Activity

  • Oct 9, 10:22 PM: @ijsong started a stack merge that includes this pull request via Graphite.
  • Oct 9, 10:22 PM: @ijsong merged this pull request with Graphite.

Base automatically changed from rename_logstreamreplicas to main October 10, 2023 02:22
@ijsong ijsong merged commit 1f42351 into main Oct 10, 2023
8 checks passed
@ijsong ijsong deleted the varlogtest_listlogstreams branch October 10, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants